Use ROS<char> for slicing in ClrNamespaceUriParser, reduce allocations #10380
+53
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on top of #9739 and allows a few more uses of
ReadOnlySpan<char>where often we don't need to materialize the output to astringobject, this time in theClrNamespaceUriParser. Keeping it a small, easy to review step like #9940 that allows to save a few allocations on common paths without any substantial changes and can be built upon further.Not really including a benchmark as its either 0 bytes allocated or the same amount when both strings need to be materialized.
Customer Impact
Increased performance, decreased allocations.
Regression
No.
Testing
Local build, unit tests.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow