Resolving PR #9436 ( Implementing ThemeMode properties ) comments #9514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3xds1nz
reviewed
Aug 2, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Aug 7, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/FluentThemeState.cs
Outdated
Show resolved
Hide resolved
h3xds1nz
reviewed
Aug 7, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs
Outdated
Show resolved
Hide resolved
h3xds1nz
reviewed
Aug 7, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs
Outdated
Show resolved
Hide resolved
hiteshkrmsft
reviewed
Aug 8, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs
Show resolved
Hide resolved
hiteshkrmsft
reviewed
Aug 8, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs
Show resolved
Hide resolved
hiteshkrmsft
reviewed
Aug 8, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs
Show resolved
Hide resolved
hiteshkrmsft
approved these changes
Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves the remaining comments on PR #9436
Testing
Local testing
Risk
Minimal
Microsoft Reviewers: Open in CodeFlow