Skip to content

Expose runner.execute to public. #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2019
Merged

Expose runner.execute to public. #416

merged 1 commit into from
Feb 26, 2019

Conversation

Oceania2018
Copy link
Contributor

@Oceania2018 Oceania2018 commented Feb 25, 2019 •
edited
Loading

I have to use the internal run method in my project which is a .NET Core based Jupyter Notebook kernel.

seesharper
seesharper approved these changes Feb 25, 2019
View reviewed changes
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no harm in exposing this as public

@seesharper seesharper requested a review from filipw February 25, 2019 21:24
filipw
filipw approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍it's sort of already "public" since you could always subclass it and access the protected member that way

@filipw filipw merged commit c294533 into dotnet-script:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seesharper seesharper seesharper approved these changes

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oceania2018 @seesharper @filipw