Discard script submission result (intentionally) #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seesharper
reviewed
Jun 4, 2020
| try | ||
| { | ||
| returnValue = await resultTask; | ||
| _ = await resultTask; |
There was a problem hiding this comment.
Can't we just do await resultTask here?
There was a problem hiding this comment.
Yes, but a discard captures the intention to deliberately ignore the return value at the call site. Just awaiting doesn't tell you if the ignorance was an omission or an intention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A non-game-changing PR to use native syntax for discarding the submission result, which makes it more obvious that it was intended.