Ignore global.json in script folder #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seesharper
commented
Aug 11, 2020
| @@ -470,7 +479,7 @@ private static string CreateTestScript(string scriptFolder) | |||
|
|
|||
| private static void CreateTestPackage(string packageLibraryFolder) | |||
| { | |||
| ProcessHelper.RunAndCaptureOutput("dotnet", "new classlib -n NuGetConfigTestLibrary", packageLibraryFolder); | |||
| ProcessHelper.RunAndCaptureOutput("dotnet", "new classlib -n NuGetConfigTestLibrary -f netstandard2.0", packageLibraryFolder); | |||
There was a problem hiding this comment.
This is needed if you have the .Net 5 SDK installed since that version no longer defaults to netstandard2.0
filipw
reviewed
Aug 11, 2020
global.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "3.1.102" | |||
There was a problem hiding this comment.
you can add here "rollForward":"latestFeature" to avoid explicit install
filipw
approved these changes
Aug 11, 2020
…dotnet-script into bugfix-working-directory
|
Great. Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that comes into play if the user has a
global.jsonfile located in the script folder that is incompatible withdotnet-script. We are pretty much tied to the 3.1 sdk sincedotnet-scriptis anetcoreapp3.1. I have seen this bug in the past also when trying to execute a script in a folder that resolves the "wrong" sdk through aglobal.jsonfile.The solution to this is to execute
dotnet restorewith the temp folder as the working directory. By temp folder I mean the folder where the generatedcsprojfile is located.Also added a
global.jsonfile to this repo as it made local testing a little bit difficult now having the .Net 5 prerelease SDK's installed. The pinned version is the same 3.1 sdk we install on the build servers.Finally also added a test that verifies that a script can run even if we have an "invalid"
global.jsonfileThis should fix #571 👍