Skip to content

conditionally reference appropriate version of Microsoft.Extensions.Logging.Console #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

conditionally reference appropriate version of Microsoft.Extensions.Logging.Console #742

merged 1 commit into from
Nov 13, 2023

Conversation

filipw
Copy link
Member

@filipw filipw commented Nov 13, 2023

For .NET 8.0 we should bring in the v8 and for .NET 7.0 the v7.

This allows us to remove the isolated load context from the test.

@filipw filipw requested a review from seesharper November 13, 2023 14:51
seesharper
seesharper approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@seesharper seesharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, perfect 👍👌

@seesharper seesharper merged commit 14e0ca7 into master Nov 13, 2023
@seesharper seesharper deleted the bugfix/conditional-dep branch November 13, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seesharper seesharper seesharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipw @seesharper