Spurious asterisk after preprocessing when using macros #11715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having something like:
```
typedef PACK(enum {
ENUMA, /**< @brief The asterisk character at the beginning of the next line is not removed, but
* becomes part of the documentation. */
}) my_enum_t;
```
and a `PREDEFINED `PACK` this leads to an `*` in the output before the word "becomes.
This is due to the, incorrect, joining of lines in case of a multi line block of comment.
doxygen
reviewed
Aug 14, 2025
| yyextra->yyLineNr++; | ||
| outputChar(yyscanner,'\n'); |
There was a problem hiding this comment.
Will this not cause the line numbers to get out of sync? (i.e. increasing yyLineNr without outputting a \n)
There was a problem hiding this comment.
I checked the linenumbers of the resulting preprocessing and they looked OK to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having something like:
and a
PREDEFINEDPACKthis leads to an*` in the output before the word "becomes. This is due to the, incorrect, joining of lines in case of a multi line block of comment.This is based on the comment: #11708 (comment)
Example: example.tar.gz