Refactor tests from unittest to pytest #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jeffwidman opened this issue Aug 4, 2017 · 1 comment

Labels

Contributor

jeffwidman commented Aug 4, 2017

For example file that should be migrated (at least part of it):
https://github.com/dpkp/kafka-python/blob/master/test/test_consumer_integration.py

This would let us use more pytest features, such as mentioned here:
#1161 (comment)

Not worth spending the time to do this for tests of old/deprecated code such as SimpleConsumer / SimpleProducer.

The text was updated successfully, but these errors were encountered:

jeffwidman mentioned this issue

Added support for offsets_for_times, beginning_offsets and end_offsets APIs. #1161

Merged

dpkp added the test coverage label

Contributor Author

jeffwidman commented Feb 12, 2020

This was handled as part of #1193 and related cleanups. We are now fully on pytest.

jeffwidman closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment