Skip to content

KafkaConnection doesn't play well with gevent #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manfre opened this issue Oct 24, 2014 · 1 comment
Closed

KafkaConnection doesn't play well with gevent #257

manfre opened this issue Oct 24, 2014 · 1 comment
Labels
enhancement

Comments

@manfre
Copy link

manfre commented Oct 24, 2014

KafkaConnection inherits from threading.local. When using gevent, this results in each greenlet having its own KafkaConnection.
manfre pushed a commit to manfre/kafka-python that referenced this issue Oct 24, 2014
Fix dpkp#257 - Allow KafkaConnection to work correctly with gevent.
331f570 
KafkaConnection inherits from threading.local, which is patched by
gevent to ensure one connection per greenlet, instead of one per
thread. If threading.local patching is detected, the base class
will be changed to object.
manfre pushed a commit to manfre/kafka-python that referenced this issue Oct 24, 2014
Fix dpkp#257 - Allow KafkaConnection to work correctly with gevent.
cb41704 
KafkaConnection inherits from threading.local, which is patched by
gevent to ensure one connection per greenlet, instead of one per
thread. If threading.local patching is detected, the base class
will be changed to object.
manfre added a commit to manfre/kafka-python that referenced this issue Oct 24, 2014
@manfre
Fix dpkp#257 - Allow KafkaConnection to work correctly with gevent.
a5599f9 
KafkaConnection inherits from threading.local, which is patched by
gevent to ensure one connection per greenlet, instead of one per
thread. If threading.local patching is detected, the base class
will be changed to object.
@dpkp
Copy link
Owner

dpkp commented Jan 30, 2016

KafkaConnection has been replaced by BrokerConnection. Closing in favor of a single issue for kombu support.

@dpkp dpkp closed this as completed Jan 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manfre @dpkp