change_subscription warning log to info #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpkp how much extra work would it save to skip calling And I agree, this log should be |
667fee6 to
a097be2
Compare
|
@jeffwidman I changed it so we don't call |
|
I would prefer to keep the log level at warning. Otherwise, this is a good improvement. +1 |
When we are using subscription by pattern change subscription is called every metadata update even when nothing changes. This PR ensures that change subscription is called only when set of topics changes.
a097be2 to
7adc692
Compare
|
@dpkp level changed back to warning |
|
Thanks! |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
When we are using subscription by pattern change subscription is called every metadata update even when nothing changes. This PR ensures that change subscription is called only when set of topics changes.
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 25, 2017
When we are using subscription by pattern change subscription is called every metadata update even when nothing changes. This PR ensures that change subscription is called only when set of topics changes.
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Oct 6, 2017
When we are using subscription by pattern change subscription is called every metadata update even when nothing changes. This PR ensures that change subscription is called only when set of topics changes.
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Jul 16, 2018
When we are using subscription by pattern change subscription is called every metadata update even when nothing changes. This PR ensures that change subscription is called only when set of topics changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are using subscription by pattern change subscription is
called every metadata update even when nothing changes. It logs
warning every time topics are not changed. It creates unnecessary
noise in logs. I changed it to level info so it can be easily ignored
(I want to see only warnings from kafka client). Do you think this is
a right approach or I should check in
ConsumerCoordinator._handle_metadata_updatethat no topics has changed and not call
change_subscriptioninthis case? I would then need to change it in aiokafka too because I'm
using that.