Make UnknownTopicOrPartitionError retriable error #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #1155 +1 on merging this, not sure if there's a reason you held off @tvoinarovskyi ? |
|
@jeffwidman https://travis-ci.org/dpkp/kafka-python/jobs/259081044 kinda want this to finish... |
|
We are still seeing periodic test failures caused by kafka fixture not starting correctly. I'm not sure what the root cause is (definitely not this change). I tend to go in to travis and restart the test when I see a fixture startup failure. Tests are all passing here, so +1 for merge. |
This was referenced Jul 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked the old client, and the error was retriable there (https://github.com/dpkp/kafka-python/blob/master/kafka/errors.py#L505), so decided there's no need to skip the retry in v0.8 brokers.