support python 3 #181
Closed
support python 3 #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add python 3 to the .travis.yml test setup and take a look at the python2.6 travis build -- test_protocol looks like it may need some cleanup. |
|
Out of curiosity: why the choice not to use six? |
|
six would definitely do it. I was thinking it would be good to keep the dependencies to minimal :) |
|
Do you mind if I take a look at this, try to make all the tests pass, and convert it over to six? |
|
That would be great. |
|
python 3 support merged to master from #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 tests from test_producer_integration are failing with python 3 but it's usable now.