Moved offset initialization to get_offsets method. #200
Conversation
This is used in initialization for auto commit but is also useful code for times when auto commit is not turned on.
|
Unless I missed something the Travis build seems to have failed only because some tests took a long time. Could someone with access rerun Travis. |
|
Done https://travis-ci.org/mumrah/kafka-python/jobs/33184891 It looks like the last build stalled/timed-out like you say On 8/21/14 12:11 PM, Tim Kuhlman wrote:
|
| kafka.common.check_error(resp) | ||
| return resp.offset | ||
| except kafka.common.UnknownTopicOrPartitionError: | ||
| return 0 |
There was a problem hiding this comment.
I think this internal callback function should be dropped in favor of explicit error checking of the response after calling send_offset_fetch_request . If we try to get offsets for an unknown partition, shouldn't we raise an exception here? Usually that signals our metadata is messed up and a full metadata refresh is in order.
|
merged #177 for 0.9.2, which moved this to consumer.fetch_last_known_offsets(partitions=None) . It modifies self.offsets directly rather than return the offsets dict, but otherwise is pretty much identical. |
The ability to pull offsets defaulting at 0 is helpful in initialization for
auto commit but is also useful code for times when auto commit is not turned
on, so it is nice to have as a method.