Minor cleanups #221
Merged
Minor cleanups #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure why the travis build didn't automatically get linked, but it passed: https://travis-ci.org/mumrah/kafka-python/jobs/34144266 |
Merged
|
This PR needs rebased |
|
rebased -- waiting on tests |
| @@ -112,9 +112,9 @@ def fetch_last_known_offsets(self, partitions=None): | |||
|
|
|||
| def get_or_init_offset_callback(resp): | |||
| try: | |||
| kafka.common.check_error(resp) | |||
There was a problem hiding this comment.
Not a big fan of static import check_error. :(
There was a problem hiding this comment.
trying to avoid the bare import kafka (which is circular) . perhaps we should import kafka.common instead?
There was a problem hiding this comment.
Sure, kafka.common is good. However, most problems I've seen with circular imports have arised from the "from X import Y" syntax.
added 7 commits
September 4, 2014 18:05
…fka.consumer, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.