Support loading cas from memory. #2237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes along cadata to SSL library. This removes the need to unnecessarily persist CA files when already present in memory.
|
Seems like something is wrong with CI? |
jeffwidman
suggested changes
Aug 3, 2021
| @@ -107,6 +107,8 @@ class KafkaAdminClient(object): | |||
| ssl_check_hostname (bool): Flag to configure whether SSL handshake | |||
| should verify that the certificate matches the broker's hostname. | |||
| Default: True. | |||
| ssl_cadata (str): optional ca filecontent to use in certificate | |||
| verification. default: None. | |||
There was a problem hiding this comment.
Can you capitalize properly?
Suggested change
| verification. default: None. | |
| ssl_cadata (str): Optional CA filecontent to use in certificate | |
| verification. Default: None. |
This applies several other places in the PR too, since this text is sorta copy/pasta.
|
We need to migrate from Travis to some other system. |
|
We don't use Kafka anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes along cadata to SSL library.
This removes the need to unnecessarily persist CA files when already
present in memory.
This change is