Python 3 support #224
Python 3 support #224
Conversation
|
thanks -- looks like some great work that hopefully someone can pick up and carry over the finish line soon. |
|
I spent some time looking at it yesterday. It passes python 2, except for the flaky test. The python 3 multiprocessing tests fail. We need to either then off nose with-id or specify an id file per target env, because the py2 tests fail to build locally due to pickle errors after running the py3 tests.
|
|
I think the py2 test failures are real. Looks like there are 3 places in |
|
Commits moved to PR #227 for final cleanup / merge. |
Hello,
I've worked on a python3-compatible branch. The goal is to have compatibility with Python 2.6-2.7 and 3.3-3.4 with the same codebase.
Most changes are actually in tests. Python 3 being stricter at bytes vs. text handling, we need to send actual bytes to Kafka. I've assumed it's safer to let the user encode data before passing it, instead of automatically using an UTF-8 encoding when seeing unicode data.
There are two remaining failing tests on Python 3: the async/multiprocessing consumer onces. I found them quite painful to debug…
I'm not planning to continue to work on it but feel free to use this branch as a starting point. Perhaps someone more familiar with the codebase can fix the remaining failing tests.