Fix error in consumer.py test against max_buffer_size #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was using max(buf_size * 2, max_buf_size), which could result in a new buffer size which exceeded the specified max_buffer_size by (max_buffer_size - 1) bytes.
|
looks like a bug! travis build failure looks like a flapper (I restarted to verify). Can you take a stab at adding a test? Should really be a unit test in test/test_consumer.py, but you could also add to integration test here: |
|
Yeah, I'll add some tests when I get some time. Work is kinda crazy right now :-) |
wizzat
pushed a commit
to wizzat/kafka-python
that referenced
this pull request
Sep 23, 2014
wizzat
added a commit
that referenced
this pull request
Sep 23, 2014
Resolve merge conflict in PR #225
|
Merged in #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using max(buf_size * 2, max_buf_size), which could result in a new
buffer size which exceeded the specified max_buffer_size by
(max_buffer_size - 1) bytes.