Fix #257 - Allow KafkaConnection to work correctly with gevent. #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KafkaConnection inherits from threading.local, which is patched by gevent to ensure one connection per greenlet, instead of one per thread. If threading.local patching is detected, the base class will be changed to object.
|
Updated PR to fix author and use type(...) instead of super().new(...). |
|
Why close? |
|
Found a potential greenlet issue where the connection can get in to a bad state. I'm still investigating and figured it was safer to close while I troubleshoot. I'm also not sure whether I'm really happy with having a single connection to kafka for all of the greenlets. |
|
Hmmm. One thing to be careful of is that the underlying kafka-python library doesn't currently handle multiplexing requests across a single connection. That might cause some serious problems if you don't keep to the current model of fully synchronous connection state (the connection is effectively blocked between calls). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KafkaConnection inherits from threading.local, which is patched by
gevent to ensure one connection per greenlet, instead of one per
thread. If threading.local patching is detected, the base class
will be changed to object.