Skip to content

Avoid RuntimeError on mutated _completed_fetches deque in consumer fetcher #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
Merged

Avoid RuntimeError on mutated _completed_fetches deque in consumer fetcher #2646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5969c14
Avoid RuntimeError on mutated _completed_fetches deque in consumer fe…
dpkp Jun 18, 2025
1847314
use copy()
dpkp Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kafka/consumer/fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,8 @@ def _handle_list_offsets_response(self, future, response):
def _fetchable_partitions(self):
fetchable = self._subscriptions.fetchable_partitions()
# do not fetch a partition if we have a pending fetch response to process
discard = {fetch.topic_partition for fetch in self._completed_fetches}
# use copy.copy to avoid runtimeerror on mutation from different thread
discard = {fetch.topic_partition for fetch in self._completed_fetches.copy()}
current = self._next_partition_records
if current:
discard.add(current.topic_partition)
Expand Down
Loading