Async producer does not silently throw away messages if Kafka is unavailable #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi imbusy -- thanks for the PR! The async producer is actually in the middle of a fairly substantial refactor here: #331 So I won't merge this PR as is, but perhaps you can take a look at PR 331 and if you believe this issue remains, can you rebase against it? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that once we find out we can't deliver a message using the asynchronous method, the producer should throw an exception when trying to enqueue new messages. The async producer constantly checks if Kafka is available again and, when it is, sends the enqueued messages and signals the main thread that it's safe to add messages again.