Skip to content

Fix value_serializer parameter in example #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2016
Merged

Conversation

scribu
Copy link
Contributor

@scribu scribu commented Mar 1, 2016

json.loads() is for deserialising.

`json.loads()` is for deserialising.
@dpkp
Copy link
Owner

dpkp commented Mar 2, 2016

Did I get those backwards? I think this should also be fixed:

>>> consumer = KafkaConsumer(value_deserializer=msgpack.dumps)

@scribu
Copy link
Contributor Author

scribu commented Mar 2, 2016

Done.

dpkp added a commit that referenced this pull request Mar 4, 2016
Fix `value_serializer` parameter in example
@dpkp dpkp merged commit d5f31e6 into dpkp:master Mar 4, 2016
@dpkp
Copy link
Owner

dpkp commented Mar 4, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants