Support for multiple hosts in KafkaClient #69
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o multihosts Conflicts: kafka/client.py kafka/conn.py
|
Build failed after appending a change not required for this fix, will submit a new pull from my master as branch is used for other stuff now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change breaks the KafkaClient constructor API but replacing the
hostandportparameters withhostsrepresented as a comma-separated list ofhost:port.E.g.
It also introduces the mock library for unit testing.
Note: some unit tests are marked as skipped until disabling recursion on
_load_metadata_for_topics, an issue I found during testing (#68).