Improve send latency with TCP_NODELAY #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmfgerrit
pushed a commit
to wikimedia/eventlogging
that referenced
this pull request
Aug 2, 2016
…reader to test dpkp/kafka-python#783 fixes a performance degradation specifically related to synchronous producing, so this comit will work best with kafka-python 1.2.6 or greater. This also DRYs the logic for getting kafka client and group ids, and adds an Event.serialize method to DRY up converting events to JSON utf-8 strings. Note that consumer balancing with kafka-python requires Kafka 0.9+ Bug: T133779 Change-Id: I3df00e9219f0a80c0805edd1df01c12fe8697341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #717
This PR enables TCP_DELAY by default to reduce send latency (possibly at the expense of throughput). To allow more general socket tuning, I've also added a configuration parameter
socket_optionswhich will be passed directly tosetsockopt()on each broker connection.