Partitioners fix #827
Merged
Partitioners fix #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had planned on removing many of these when SimpleProducer is removed. Do you think these partitioners are still useful w/ the new KafkaProducer ? |
|
The changes are made so the old partitioners work with the new KafkaProducer, while still maintaining support for the old producers. |
|
Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partitioners have been updated to use the new KafkaProducer calls and support the old SimpleProducer APIs.
The partitioners are callable and the RoundRobinPartitioner caches the last partition and supports dynamic partition altering.