Skip to content

Fix of wrong MetadataRequest in case of empty topics list #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2016
Merged

Fix of wrong MetadataRequest in case of empty topics list #867

merged 1 commit into from
Nov 18, 2016

Conversation

sibiryakov
Copy link
Contributor

@sibiryakov sibiryakov commented Nov 1, 2016 •
edited
Loading

topics were set to [] instead of None because of empty self._topics set for MetadataRequest_v1

@sibiryakov
Copy link
Contributor Author

sibiryakov commented Nov 11, 2016 •
edited
Loading

@dpkp Hi Dana, please have a look at this. It shouldn't take much time, but it's blocking our https://github.com/scrapinghub/frontera release. Ty!

@dpkp dpkp merged commit af7f2ce into dpkp:master Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sibiryakov @dpkp