Sort partitions before calling partitioner #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current partitioners assume that the partitions are sorted according to partition ID in all_partitions. However, this is not guaranteed in the KafkaProducer implementation as the values that are passed come from a set. Sets are not guaranteed to iterate values in any particular order, so we need to sort the values before passing them further along. Before this change, the code depended on internal implementation of Python interpreters. In CPython 3.5 and lower it seems that integers are returned in sorted order from sets so the code appears to work. In PyPy and CPython 3.6, sets and dictionaries preserve the order of insertions [1] which means that the code may not work in these environments (I have not tested this). As far as I could find, the order of partitions used in this case is the order that is returned by the broker, but the documentation does not say anything about partition order. [1] https://docs.python.org/3.6/whatsnew/3.6.html#whatsnew36-compactdict
dpkp
reviewed
Dec 18, 2016
| @@ -625,7 +625,7 @@ def _partition(self, topic, partition, key, value, | |||
| assert partition in self._metadata.partitions_for_topic(topic), 'Unrecognized partition' | |||
| return partition | |||
|
|
|||
| all_partitions = list(self._metadata.partitions_for_topic(topic)) | |||
| all_partitions = sorted(list(self._metadata.partitions_for_topic(topic))) | |||
There was a problem hiding this comment.
sorted will operate on a set, so I think we can drop the explicit list conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current partitioners assume that the partitions are sorted according
to partition ID in all_partitions. However, this is not guaranteed
in the KafkaProducer implementation as the values that are passed
come from a set. Sets are not guaranteed to iterate values in any
particular order, so we need to sort the values before passing
them further along.
Before this change, the code depended on internal implementation of
Python interpreters. In CPython 3.5 and lower it seems that integers
are returned in sorted order from sets so the code appears to work.
In PyPy and CPython 3.6, sets and dictionaries preserve the order
of insertions [1] which means that the code may not work in these
environments (I have not tested this). As far as I could find,
the order of partitions used in this case is the order that is
returned by the broker, but the documentation does not say anything
about partition order.
[1] https://docs.python.org/3.6/whatsnew/3.6.html#whatsnew36-compactdict