Fix: CLI hanging issue - implement resource cleanup #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cleanup utility to terminate browser sessions and shell processes\n- Update BrowserManager with better process exit handling\n- Add force exit as a failsafe\n- Export necessary components for cleanup\n\nFixes #141
|
🎉 This PR is included in version mycoder-agent-v1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version mycoder-v1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CLI Hanging Issue
Problem
The mycoder CLI sometimes hangs and doesn't return to the shell even after showing a performance summary. This is caused by unresolved promises, open browser sessions, and running shell processes that prevent the Node.js process from exiting.
Solution
This PR implements a comprehensive cleanup system that ensures all resources are properly released before the CLI exits:
Added a new cleanup utility (
packages/cli/src/utils/cleanup.ts) that:Updated the BrowserManager to:
beforeExitfor async cleanupModified the main CLI entry point to:
finallyblockTesting
This change can be tested by running the CLI with commands that use browser or shell tools and verifying that the CLI properly exits after completion.
Fixes #141
Related to #202