Add Support for Short-Lived Tokens #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add token_access_type to oauth flow - Legacy - default - the current long lived token flow - Online - requests only a short-lived access token - Offline - requests both a short-lived access token and a refresh token Add refresh check to each API call Add refresh check on client creation
jiuyangzhao
suggested changes
Mar 26, 2020
dropbox/dropbox.py
Outdated
| @@ -191,9 +210,15 @@ def __init__(self, | |||
|
|
|||
| self._timeout = timeout | |||
|
|
|||
| self._check_and_refresh_access_token() | |||
There was a problem hiding this comment.
Normally we want to avoid network call in constructor. I think its OK to not validate it here. (Like we don't validate if oauth2 token to server)
jiuyangzhao
reviewed
Mar 27, 2020
jiuyangzhao
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add token_access_type to oauth flow
- Legacy - default - the current long lived token flow
- Online - requests only a short-lived access token
- Offline - requests both a short-lived access token and a refresh token
Add refresh check to each API call
Add refresh check on client creation