Add Support for PKCE #187
Merged
Add Support for PKCE #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rogebrd
commented
Apr 1, 2020
- Add Support for PKCE in OAuth Flow
- Add unit tests for oauth flow
- Add example for command line with PKCE
- Make client secret optional for PKCE
jiuyangzhao
suggested changes
Apr 2, 2020
dropbox/oauth.py
Outdated
| def __init__(self, consumer_key, consumer_secret, locale=None, token_access_type='legacy', | ||
| scope=None, include_granted_scopes=None): | ||
| def __init__(self, consumer_key, consumer_secret=None, locale=None, token_access_type='legacy', | ||
| scope=None, include_granted_scopes=None, pkce_method=None): |
There was a problem hiding this comment.
I think it make no sense to ever provide plain here. We should always use s256.
And still leave a boolean like "use_pkce"
dropbox/oauth.py
Outdated
| def __init__(self, consumer_key, consumer_secret, locale=None, token_access_type='legacy', | ||
| scope=None, include_granted_scopes=None): | ||
| def __init__(self, consumer_key, consumer_secret=None, locale=None, token_access_type='legacy', | ||
| scope=None, include_granted_scopes=None, pkce_method=None): | ||
| if scope is not None: | ||
| assert len(scope) > 0 and isinstance(scope, list), \ |
There was a problem hiding this comment.
BTW I think it is time to point out that.
Assertion Error should be use when you are absolutely sure that the input can't be False. For this type of user error, we should throw other exceptions.
dropbox/oauth.py
Outdated
| @@ -412,10 +456,19 @@ def __init__(self, consumer_key, consumer_secret, redirect_uri, session, | |||
| user - include user scopes in the grant | |||
| team - include team scopes in the grant | |||
| Note: if this user has never linked the app, include_granted_scopes must be None | |||
| :param str pkce_method: method for code_challenge generation if using PKCE | |||
There was a problem hiding this comment.
Again I feel we should just use a boolean here:
And the doc string should be more lean toward something like: "PKCE should be only use on client apps which doesn't call your server. It is less secure than non-PKCE flow".
jiuyangzhao
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.