Improve experience for contributors #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braincore
pushed a commit
that referenced
this pull request
Sep 26, 2015
- Remove forgotten debug print statement. - Make tests launchable from anywhere. - Fix tests after "reason"/"error" refactoring.
braincore
pushed a commit
that referenced
this pull request
Sep 26, 2015
- Remove forgotten debug print statement. - Make tests launchable from anywhere. - Fix tests after "reason"/"error" refactoring.
|
Since we have our own build and release process, I've committed your changes outside of the GitHub flow. Thanks a lot! |
|
Oh! And I'll make a task to investigate tox. |
|
FYI, I've added support for using tox. Thanks for the tip! |
|
My pleasure ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
You left a print statement in an earlier commit, so I wanted to make a pull request for removing it. While doing so, I forked the repo and launched the tests, and it failed because you need to be inside the test folder for it to run correctly, but that's just because the files around are accessed through a direct path, so I propose a small change that gives room for more flexibility.
Finally, 2 of your tests were initially failing after the recent ".reason"/".error" refactoring, so I fixed them.
If you prefer, 3 different pull requests, just tell me.
Would you be ok to using tox instead of calling "python2" and "python3" directly in runtests. For those using virtualenvs instead of globally installing packages, that can smooth this a lot.