Skip to content

Expiration bug fix #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2020
Merged

Expiration bug fix #195

merged 2 commits into from
May 7, 2020

Conversation

rogebrd
Copy link
Contributor

@rogebrd rogebrd commented May 7, 2020

  • Fix parameter bug from expires_in to expiration to match constructor
  • Remove code examples from oauth and link to examples directory

@rogebrd rogebrd linked an issue May 7, 2020 that may be closed by this pull request
Issue on oauth finish #194
Closed
emmaworley
emmaworley approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@emmaworley emmaworley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rogebrd rogebrd merged commit 417ab9c into master May 7, 2020
@rogebrd rogebrd deleted the expiration_bug_fix branch May 7, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@emmaworley emmaworley emmaworley approved these changes

@jiuyangzhao jiuyangzhao jiuyangzhao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue on oauth finish
3 participants
@rogebrd @emmaworley @jiuyangzhao