Skip to content

Ensure Dropbox error is thrown in refresh access token #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 19, 2022
Merged

Ensure Dropbox error is thrown in refresh access token #407

merged 7 commits into from
Jan 19, 2022

Conversation

Brent1LT
Copy link
Contributor

Separate out error handling into another method for the dropbox client so that it can be reused in refresh_access_token since it previously didn't throw a Dropbox error when the status code was anything other than a 400.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

@codecov
Copy link

codecov bot commented Jan 12, 2022 •
edited
Loading

Codecov Report

Merging #407 (096606b) into main (0154374) will increase coverage by 0.00%.
The diff coverage is 73.52%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   64.23%   64.23%           
=======================================
  Files          30       30           
  Lines       51443    51451    +8     
  Branches     5728     5729    +1     
=======================================
+ Hits        33043    33049    +6     
- Misses      18243    18244    +1     
- Partials      157      158    +1
Flag Coverage Δ
integration 64.14% <64.70%> (+<0.01%) ⬆️
unit 63.65% <26.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dropbox/dropbox_client.py 72.78% <73.52%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0154374...096606b. Read the comment docs.

rogebrd
rogebrd approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@rogebrd rogebrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but please get CI working first

@Brent1LT Brent1LT force-pushed the refresh_error_handling branch from 8981175 to 04c58ea Compare January 12, 2022 21:55
@Brent1LT Brent1LT merged commit 62e49c1 into main Jan 19, 2022
@Brent1LT Brent1LT deleted the refresh_error_handling branch January 19, 2022 18:38
@samschott samschott mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rogebrd rogebrd rogebrd approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brent1LT @rogebrd