Skip to content

Fix invalid specifier in stone requirement #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix invalid specifier in stone requirement #456

merged 1 commit into from
Apr 5, 2023

Conversation

sagarvora
Copy link
Contributor

As mentioned in pypa/pip-audit#445 (comment):

PEP 440 doesn't say it directly, but the language implies that the .* is only valid on exact comparison operators (e.g. == and !=), nor ordered comparisons (e.g. >=).

In particular, a comparison like >=3.5.* is redundant: it has the exact same meaning as >=3.5.

This is causing pip-audit to fail, like so:
https://github.com/frappe/frappe/actions/runs/3811860090/jobs/6484759800#step:4:183

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

@sagarvora sagarvora mentioned this pull request Dec 31, 2022
Merged
@greg-db
Copy link
Contributor

greg-db commented Jan 2, 2023

Thanks for sharing this! I'll ask the team to review this.

@sagarvora sagarvora mentioned this pull request Jan 6, 2023
Closed
@barredterra
Copy link

I just spent an hour trying to solve this problem. But of course @sagarvora is weeks ahead 😁

This was referenced Jan 24, 2023
Merged
Merged
@sagarvora
Copy link
Contributor Author

@greg-db Any update?

@greg-db
Copy link
Contributor

greg-db commented Mar 3, 2023

@sagarvora This is still open with the team, but I don't have an update on it yet.

sderickson
sderickson approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@sderickson sderickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay.

@sderickson sderickson self-requested a review April 4, 2023 15:41
@sderickson
Copy link
Contributor

Hmm, the checks aren't running for this PR for some reason. Might try adding another commit just to get things going. Will pick at it also.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sagarvora
Copy link
Contributor Author

sagarvora commented Apr 5, 2023 •
edited
Loading

Hi @sderickson,

Thanks for approving the PR.

Edit: Checks are running now. Integrations tests are failing -probably because secrets are only accessible by Dropboxers.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #456 (c87d4f7) into main (9895d70) will decrease coverage by 0.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
- Coverage   64.26%   63.69%   -0.58%     
==========================================
  Files          31       31              
  Lines       52609    52609              
  Branches     3841     3841              
==========================================
- Hits        33810    33510     -300     
- Misses      18638    19064     +426     
+ Partials      161       35     -126
Flag Coverage Δ
integration ?
unit 63.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sderickson sderickson merged commit c8aac23 into dropbox:main Apr 5, 2023
@sagarvora sagarvora deleted the fix-stone-req branch April 5, 2023 16:53
@sagarvora sagarvora mentioned this pull request Apr 6, 2023
Closed
@samschott samschott mentioned this pull request Apr 6, 2023
Closed
@sagarvora
Copy link
Contributor Author

@sderickson Can we release this please? It should fix #458 and close #464.

@SFrijters SFrijters mentioned this pull request Apr 17, 2023
Closed
12 tasks
@sagarvora
Copy link
Contributor Author

@sderickson The release v11.36.1 doesn't show on PyPI. Did you miss a step?

@greg-db
Copy link
Contributor

greg-db commented Apr 18, 2023

@sagarvora Thanks for the note. That release has not been successfully added on PyPI. We'll follow up once we have an update.

@ghane
Copy link

ghane commented May 16, 2023

Hi, could you please push this to PyPi? I am trying to install a downstream dependant, and this is making that uninstallable.

Thank you

@greg-db
Copy link
Contributor

greg-db commented May 16, 2023

@ghane Thanks for the note! This is open with the team. I'll follow up here once that's published to PyPI.

@sderickson sderickson mentioned this pull request Jun 12, 2023
Open
@greg-db
Copy link
Contributor

greg-db commented Jun 13, 2023

v11.36.2 is now published on PyPI.

@greg-db greg-db mentioned this pull request Jun 13, 2023
Closed
6 tasks
@ichard26 ichard26 mentioned this pull request Dec 31, 2023
Closed
1 task
@barredterra barredterra mentioned this pull request Jan 14, 2024
Merged
srstsavage added a commit to srstsavage/d1_python that referenced this pull request Sep 15, 2024
@srstsavage
Upgrade dropbox to fix dependency metadata problem
b65d79b 
Upgrade dropbox dependency to 11.36.2 to avoid a dependency metadata issue.

Without this fix, `pip install -r requirements.txt` fails in pip >=24.1
with the following error:

```
WARNING: Ignoring version 11.36.0 of dropbox since it has invalid metadata:
Requested dropbox==11.36.0 from https://files.pythonhosted.org/packages/11/7e/e66327f3535cf5b58b3c152144744fc5727355357304facf61e43ab1b895/dropbox-11.36.0-py3-none-any.whl (from -r requirements.txt (line 46)) has invalid metadata: .* suffix can only be used with `==` or `!=` operators
    stone (>=2.*)
           ~~~~^
Please use pip<24.1 if you need to use this version.
```

Fixed in dropbox-sdk-python here:

dropbox/dropbox-sdk-python#456
@srstsavage srstsavage mentioned this pull request Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sderickson sderickson sderickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sagarvora @greg-db @barredterra @sderickson @CLAassistant @ghane