Skip to content

Add print PHP_CodeSniffer and PHP-CS-Fixer versions when --version #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2024
Merged

Add print PHP_CodeSniffer and PHP-CS-Fixer versions when --version #201

merged 4 commits into from
May 7, 2024

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented May 5, 2024 •
edited
Loading

resolve #200

スクリーンショット 2024-05-06 17 01 20

samsonasik
samsonasik requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How different on after shouldPrintMetaInformation() on line 70?

@samsonasik
Copy link
Collaborator

is the shouldPrintMetaInformation() no longer reachable? when it executed?

@zonuexe
Copy link
Contributor Author

zonuexe commented May 6, 2024

@samsonasik

is the shouldPrintMetaInformation() no longer reachable? when it executed?

The output with the version number at the beginning when started with --output-format=console has not changed.

スクリーンショット 2024-05-06 20 27 59

@samsonasik
Copy link
Collaborator

can shouldPrintMetaInformat() check be moved before --version check?, then, no need double print long version.

I prefer to keep existing return parent::run() if possible to avoid break tho

@samsonasik
Copy link
Collaborator

LGTM, let's give it a try, thank you @zonuexe

@samsonasik samsonasik merged commit bab4954 into easy-coding-standard:main May 7, 2024
7 checks passed
@TomasVotruba
Copy link
Contributor

Thank you @zonuexe 🎉

@zonuexe zonuexe deleted the print-versions branch May 7, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a command to show Php CS fixer version
3 participants
@zonuexe @samsonasik @TomasVotruba