Skip to content

Add new output formatter for checkstyle #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2024
Merged

Add new output formatter for checkstyle #204

merged 3 commits into from
May 21, 2024

Conversation

M-arcus
Copy link
Contributor

@M-arcus M-arcus commented May 17, 2024

The use case for this are CI checks that add simple and easy to read annotations to GitHub pull requests via cs2pr.

The code is adapted from PHP-CS-Fixer that already possesses this output format.

I have also added a test for this new output format.

@samsonasik
Copy link
Collaborator

I updated rector to ^1.0 to fix rector notice at

Could you rebase? thank you.

@M-arcus
Copy link
Contributor Author

M-arcus commented May 18, 2024

I have rebased the branch

@samsonasik
Copy link
Collaborator

Please run:

vendor/bin/rector && composer fix-cs

To apply rector and cs

@M-arcus
Copy link
Contributor Author

M-arcus commented May 18, 2024

Both have been applied, I force-pushed the fixed code

@TomasVotruba TomasVotruba requested a review from samsonasik May 21, 2024 07:36
@TomasVotruba TomasVotruba enabled auto-merge (squash) May 21, 2024 16:23
@TomasVotruba
Copy link
Contributor

Thank you @M-arcus 🥳

@TomasVotruba TomasVotruba disabled auto-merge May 21, 2024 16:44
@TomasVotruba TomasVotruba merged commit 25be729 into easy-coding-standard:main May 21, 2024
7 checks passed
@M-arcus
Copy link
Contributor Author

M-arcus commented May 22, 2024

Is a release with this feature planned soon?

@TomasVotruba
Copy link
Contributor

We usually release once a couple weeks. To give time for dev testing and feedback loop before we release it to public.

@samsonasik
Copy link
Collaborator

@TomasVotruba easy-coding-standard latest release was on february, I think we can have new release

@samsonasik
Copy link
Collaborator

@M-arcus easy-coding-standard 12.2.0 tagged https://github.com/easy-coding-standard/easy-coding-standard/releases/tag/12.2.0

@M-arcus
Copy link
Contributor Author

M-arcus commented May 23, 2024

@samsonasik Thank you 😊

@M-arcus M-arcus deleted the add-checkstyle branch May 23, 2024 08:13
@Kenneth-Sills Kenneth-Sills mentioned this pull request May 26, 2024
Closed
@nlemoine
Copy link

nlemoine commented Jun 3, 2024

So glad you changed your mind 🙂 #124

Thanks you for this!

@TomasVotruba
Copy link
Contributor

@nlemoine Thanks 👍 Well done PRs are quite convincing 😆

@nlemoine
Copy link

nlemoine commented Jun 3, 2024

Indeed! 😄 Great work and thank you too @M-arcus 🙂

@M-arcus
Copy link
Contributor Author

M-arcus commented Jun 3, 2024

Happy to get the chance to contribute to a repository I use everyday 😃

nlemoine added a commit to timber/timber that referenced this pull request Jun 7, 2024
@nlemoine
ci: Add cs2pr for ECS which now supports checktyle format
d452ba4 
See: easy-coding-standard/easy-coding-standard#204
@nlemoine nlemoine mentioned this pull request Jun 7, 2024
Merged
nlemoine added a commit to timber/timber that referenced this pull request Jun 7, 2024
@nlemoine
ci: Add cs2pr for ECS which now supports checktyle format (#3010)
d84910d 
See: easy-coding-standard/easy-coding-standard#204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M-arcus @samsonasik @TomasVotruba @nlemoine