Avoid change chmod by using Nette\Utils\FileSystem with pass null on 3rd argument on write #209
Conversation
…3rd argument on write
|
@vasilvestre could you verify this patch? Thank you. |
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| namespace Symplify\EasyCodingStandard\Caching\ValueObject\Storage; | |||
|
|
|||
| use Nette\Utils\FileSystem as UtilsFileSystem; | |||
There was a problem hiding this comment.
@vasilvestre for manual test, with directly change on vendor, change it with prefixed use statement:
use ECSPrefix202405\Nette\Utils\FileSystem as UtilsFileSystem;|
It's not working for me, the ownership still changes to root:root despite an original user with UID 1000 |
|
I am not sure why it can change ownership, chaning chmod is what we seen in the past, but ownership is strange as it should not know what new one, it probably related with somewhere on your php setting and executable as user you run. I suggest to not run on docker as it may be the root of the issue. I will may still merge it to sync with rector. |
|
@TomasVotruba I am merging it so we have sync usage with rector ;) |
Not an option in our workflow. Thank you for the test tho ! |
This patch should equal with what Rector has:
and avoid symfony issue on rename.