Improve Reliability of Configuration Caching #226
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
Each commit message body includes details on the changes made, but as a whole I've refactored the
FileHashComputer
so that instead of just using the class names of services and rules for hashing material, it also uses the internal state in order to capture configuration.Since we did experience this regression, and caching issues are often hard to notice, I made sure to update the related testing suite to include many more test cases. Given the nature of global / static state, it's a bit annoying. But I added a comment for maintainers to understand why it must be structured the way it is.