Skip to content

Stop Reporting Duplicate Errors for Sniffs in the Presence of Fixable Changes #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Stop Reporting Duplicate Errors for Sniffs in the Presence of Fixable Changes #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb2aa0
fix(phpcs): stop reporting duplicate unfixable errors with fixable ch…
Kenneth-Sills Jun 19, 2024
963b708
Merge branch 'main' into kesills-duplicate-sniff-errors-with-fixes
TomasVotruba Jan 31, 2025
9393291
Merge branch 'main' into kesills-duplicate-sniff-errors-with-fixes
TomasVotruba Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/SniffRunner/DataCollector/SniffMetadataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ public function reset(): void
$this->codingStandardErrors = [];
}

public function resetErrors(): void
{
$this->codingStandardErrors = [];
}

public function addCodingStandardError(CodingStandardError $codingStandardError): void
{
$this->codingStandardErrors[] = $codingStandardError;
Expand Down
4 changes: 4 additions & 0 deletions src/SniffRunner/ValueObject/File.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ public function __construct(
*/
public function process(): void
{
// Since sniffs are re-run after they do fixes, we need to clear the old
// errors to avoid duplicates.
$this->sniffMetadataCollector->resetErrors();

$this->parse();
$this->fixer->startFile($this);

Expand Down