Fix: Correctly Apply Symfony Output Flags #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, anything set by `Application::configureIO()` in a "normal" Symfony Application (we do things a little differently). Because we construct our styles separately from the application, during DI initialization, I had to copy the code that handles Symfony's arguments into here. This isn't an exact copy and paste, but given I did start from their source and work it into what's committed here, I felt it appropriate to include their MIT licensing in the NOTICE. Closes easy-coding-standard#213
Since the numeric `--verbose` doesn't work with Symfony, might as well remove the code to handle it.
|
I'm going through old PRs that are good to go, but I forgot to do the last step. Let's ship this :) Thank you for your patience and work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, anything set by
Application::configureIO()in a "normal" Symfony Application (we do things a little differently).Because we construct our styles separately from the application, during DI initialization, I had to copy the code that handles Symfony's arguments into here. This isn't an exact copy and paste, but given I did start from their source and work it into what's committed here, I felt it appropriate to include their MIT licensing in the NOTICE.
Closes #213
I did not include automated tests, but I did manually test
-q/--quietand--ansi/--no-ansiand-v[v][v].I'd like to preemptive point out that
--verbose=ndoes not work, this is a known issue with Symfony.