Skip to content

[IMP] SuperfluousConfigurationException message for the "common" set #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matteotrubini
Copy link
Contributor

The error message lists all sets that should be removed, as they are already included, providing clearer guidance to the user.

@TomasVotruba
Copy link
Contributor

TomasVotruba commented Mar 31, 2025

This bothered me as well. PR looks good 👍

Could you fix the CI? I'll merge it then

@matteotrubini matteotrubini force-pushed the imp/error-message-common-set branch from d139630 to 86c1a68 Compare March 31, 2025 15:42
@matteotrubini
Copy link
Contributor Author

matteotrubini commented Mar 31, 2025

OK, I think I just realized why:

https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/releases/tag/v3.74.0

fix: OrderedImportsFixer - do not take the braces part in grouped imports into account

PHP-CS-Fixer/PHP-CS-Fixer#8459

@TomasVotruba
Copy link
Contributor

Merged, thank you.

This PR needs rebase now

The error message lists all sets that should be removed, as they are already included, providing clearer guidance to the user.
@matteotrubini matteotrubini force-pushed the imp/error-message-common-set branch from 86c1a68 to db82e6a Compare April 1, 2025 06:33
@TomasVotruba
Copy link
Contributor

Thank you 🙏

@TomasVotruba TomasVotruba merged commit f1fab01 into easy-coding-standard:main Apr 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants