Powershell Version of Binary Search #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First Commit of a powershell version of Bianry Search. Please let me how it can be improved.
|
Hi, |
egonSchiele
requested changes
May 18, 2017
|
|
||
| while ($low -lt $high) { | ||
|
|
||
| $mid = ($low + $high); |
There was a problem hiding this comment.
This should be $mid = ($low + $high) / 2;. The code is wrong in the book (it is a known bug).
Instead of $mid = ($low + $high); I made the change as requested to $mid = ($low + $high) / 2;
|
I made the change to to reflect $mid = ($low + $high) / 2;. |
itadder
commented
May 19, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Commit of a PowerShell version of Binary Search. Please let me how it can be improved.
This is my first attempt to port the algorithms in the book to Powershell. Hope this helps others, I will on the others as I go on in the book in Powershell. Since PowerShell is now open source, and available to others in Linux, mac, and windows it should work cross platform.