C# selection sort implementation for in-place sorting without additional arrays #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @egonSchiele, have you had a chance to take a look at it? |
|
@pfrontera I don't know much about C sharp, is there a reason to prefer an array over a |
|
Hi @egonSchiele , because behind the scene, when a list modifies its size is creating an array. This way I’m proposing I’m ordering the same reference/origin input without creating new lists for ordering on the way. |
|
I think its the same that @sergiovanovi made on java. |
|
Hi again @egonSchiele I believe there might have been some confusion in my previous description. I have now revised it to provide a more accurate explanation. Thanks |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have replaced the usage of additional arrays as a crutch with an in-place sorting approach. This means that I modified the code to directly perform the sorting on the original array, instead of relying on extra arrays for assistance.