Skip to content

Minor fix in 01_binary_search.cpp #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2024
Merged

Minor fix in 01_binary_search.cpp #271

merged 1 commit into from
Dec 7, 2024

Conversation

MahmoudHamdy00
Copy link
Contributor

use template to the item that we are search for

@MahmoudHamdy00
Update 01_binary_search.cpp
62782aa 
use template to the item that we are search for
@egonSchiele
Copy link
Owner

I like this change, but lower in the file we're comparing guess and item:

if (guess > item)

Is there a way to indicate in C++ that T can be any type that is comparable?

@egonSchiele egonSchiele merged commit c06ad95 into egonSchiele:master Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MahmoudHamdy00 @egonSchiele