Skip to content

feat: add app.getRecentDocuments() #45839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

feat: add app.getRecentDocuments() #45839

merged 1 commit into from
Jul 31, 2025

Conversation

codebytere
Copy link
Member

Description of Change

As in title - allows getting recent documents. Also allows testing other recent document functionality.

Checklist

Release Notes

Notes: Added support for app.getRecentDocuments() on Windows and macOS.

@codebytere codebytere added semver/minor backwards-compatible functionality target/35-x-y PR should also be added to the "35-x-y" branch. labels Feb 27, 2025
@codebytere codebytere requested a review from a team February 27, 2025 17:45
@codebytere codebytere force-pushed the get-recent-documents branch 3 times, most recently from 5b3d8f7 to 9f59744 Compare February 27, 2025 18:12
ckerr
ckerr reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor lint failures:

   api/app.md
         770:28:   Extra semicolon.
         772:41:   Extra semicolon.

nikwen
nikwen reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature!

@codebytere codebytere force-pushed the get-recent-documents branch from 9f59744 to b2b171b Compare March 3, 2025 09:48
@codebytere codebytere requested a review from ckerr March 3, 2025 10:20
@github-actions github-actions bot added the target/36-x-y PR should also be added to the "36-x-y" branch. label Mar 5, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 6, 2025
erickzhao
erickzhao approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

samuelmaddock
samuelmaddock approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@ckerr
Copy link
Member

ckerr commented Mar 21, 2025

The CI failures seem to be related to the new feature:

2025-03-21T05:47:23.3331910Z not ok 29 app module app.{add|get|clear}RecentDocument(s) can add a recent document
2025-03-21T05:47:23.3334410Z   expected [] to be a superset of [ '/Users/runner/work/electron/electron/src/electron/spec/fixtures/foo.txt' ]
2025-03-21T05:47:23.3336950Z   AssertionError: expected [] to be a superset of [ '/Users/runner/work/electron/electron/src/electron/spec/fixtures/foo.txt' ]
2025-03-21T05:47:23.3346380Z       at Context.<anonymous> (electron/spec/api-app-spec.ts:383:51)
2025-03-21T05:47:23.4009370Z not ok 30 app module app.{add|get|clear}RecentDocument(s) can clear recent documents
2025-03-21T05:47:23.4014200Z   expected [] to be a superset of [ '/Users/runner/work/electron/electron/src/electron/spec/fixtures/bar.txt', '/Users/runner/work/electron/electron/src/electron/spec/fixtures/baz.txt' ]
2025-03-21T05:47:23.4019360Z   AssertionError: expected [] to be a superset of [ '/Users/runner/work/electron/electron/src/electron/spec/fixtures/bar.txt', '/Users/runner/work/electron/electron/src/electron/spec/fixtures/baz.txt' ]
2025-03-21T05:47:23.4021360Z       at Context.<anonymous> (electron/spec/api-app-spec.ts:390:51)
2025-03-21T05:47:24.1863160Z [16046:0321/054724.184462:ERROR:kill_posix.cc(33)] waitpid(16054): No child processes (10)
2025-03-21T05:47:24.1863870Z

@codebytere
Copy link
Member Author

@ckerr yeah i was struggling a little to get the tests to be properly idempotent 😅 will tackle next week!

@codebytere codebytere force-pushed the get-recent-documents branch 2 times, most recently from 25bf638 to 6aaf99f Compare April 10, 2025 11:12
@github-actions github-actions bot added the target/37-x-y PR should also be added to the "37-x-y" branch. label Apr 29, 2025
@github-actions github-actions bot added the target/38-x-y PR should also be added to the "38-x-y" branch. label Jun 24, 2025
@codebytere codebytere force-pushed the get-recent-documents branch from 6aaf99f to 5871adb Compare July 17, 2025 13:48
@codebytere codebytere removed the target/35-x-y PR should also be added to the "35-x-y" branch. label Jul 18, 2025
@codebytere codebytere force-pushed the get-recent-documents branch from 5871adb to 260f615 Compare July 18, 2025 09:22
@codebytere codebytere force-pushed the get-recent-documents branch from 260f615 to c760df0 Compare July 31, 2025 09:14
@codebytere
Copy link
Member Author

macOS test runner froze and the frozen test shard isn't the one that has the newly added tests - they are all passing on arm64!

@codebytere codebytere merged commit ecb1eb0 into main Jul 31, 2025
99 of 104 checks passed
@codebytere codebytere deleted the get-recent-documents branch July 31, 2025 14:15
@release-clerk
Copy link

release-clerk bot commented Jul 31, 2025

Release Notes Persisted

Added support for app.getRecentDocuments() on Windows and macOS.

This was referenced Jul 31, 2025
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 31, 2025

I have automatically backported this PR to "37-x-y", please check out #47923

@trop trop bot mentioned this pull request Jul 31, 2025
Merged
@trop trop bot removed the target/37-x-y PR should also be added to the "37-x-y" branch. label Jul 31, 2025
@trop
Copy link
Contributor

trop bot commented Jul 31, 2025

I have automatically backported this PR to "38-x-y", please check out #47924

@trop
Copy link
Contributor

trop bot commented Jul 31, 2025

I have automatically backported this PR to "36-x-y", please check out #47925

@trop trop bot added in-flight/38-x-y in-flight/36-x-y merged/36-x-y PR was merged to the "36-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. and removed target/38-x-y PR should also be added to the "38-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. in-flight/36-x-y in-flight/38-x-y in-flight/37-x-y labels Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikwen nikwen nikwen left review comments

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@erickzhao erickzhao erickzhao approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
api-review/approved ✅ merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. merged/38-x-y PR was merged to the "38-x-y" branch. semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @ckerr @samuelmaddock @nikwen @erickzhao