-
Notifications
You must be signed in to change notification settings - Fork 16k
feat: add support for --experimental-network-inspection
#46690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
💖 Thanks for opening this pull request! 💖 Semantic PR titlesWe use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Commit signingThis repo enforces commit signatures for all incoming PRs. PR tipsThings that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
4e877b3
to
06d18b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically approving the concept of this from a security standpoint given the fuse implication, this is correctly gated behind the debug fuse and as such doesn't expose substantially more surface area IMO.
patches/node/inspector_add_network_initiator_in_inspector_protocol.patch
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/electron/electron/blob/main/docs/api/command-line-switches.md#nodejs-flags should be updated to include the new flag --experimental-network-inspection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmm1 looks good, but you need to sign your commits before we can merge this:
This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.
f054a1a
to
4ef9f04
Compare
Sorry, I think I fixed it. |
Description of Change
Allow
--experimental-network-inspection
to be used in NODE_OPTIONS.Includes nodejs/node#56805
cc @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Added support for node option
--experimental-network-inspection