refactor: add NativeWindow::IsActive() #47148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was already present on macOS; use in NativeWindowViews too
codebytere
approved these changes
May 19, 2025
jkleinsc
approved these changes
May 20, 2025
|
No Release Notes |
codebytere
pushed a commit
that referenced
this pull request
Aug 8, 2025
this was already present on macOS; use in NativeWindowViews too
codebytere
pushed a commit
that referenced
this pull request
Aug 8, 2025
this was already present on macOS; use in NativeWindowViews too
codebytere
added a commit
that referenced
this pull request
Aug 8, 2025
…8012) * fix: window accentColor should adhere to native window behavior Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * fix: address review feedback Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * chore: remove duplicate UpdateWindowAccentColor call in ctor Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * refactor: add NativeWindow::IsActive() (#47148) this was already present on macOS; use in NativeWindowViews too --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
codebytere
added a commit
that referenced
this pull request
Aug 9, 2025
…8011) * fix: window accentColor should adhere to native window behavior Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * fix: address review feedback Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * chore: remove duplicate UpdateWindowAccentColor call in ctor Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> * refactor: add NativeWindow::IsActive() (#47148) this was already present on macOS; use in NativeWindowViews too --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was already present on macOS; use in NativeWindowViews too
Description of Change
Part 4 in a short series of PRs to reduce public use of
NativeWindow::widget()so that it can be made into a protected method. See Part 1 for discussion of why I want to do that.This PR adds
NativeWindow::IsActive()on all platforms, when previously it existed only on macOS builds.WebContents::ReadyToCommitNavigation()can use this method instead of callingNativeWindow::widget()->IsActive()on Windows and Linux.Checklist
npm testpassesRelease Notes
Notes: none.