ci: use new arc cluster #47897
Merged
ci: use new arc cluster #47897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5140541 to
ff12828
Compare
ff12828 to
870de13
Compare
b249b16 to
73c9720
Compare
73c9720 to
d3055e3
Compare
Comment on lines
+39
to
+44
| echo "const fs = require('fs');" > gettoken.js | ||
| echo "const fileContents = fs.readFileSync('sas-token', 'utf8');" >> gettoken.js | ||
| echo "const token = JSON.parse(fileContents);" >> gettoken.js | ||
| echo "console.log(token[process.argv[2]])" >> gettoken.js | ||
| sas_token=$(node ./gettoken.js sasToken) | ||
| account_name=$(node ./gettoken.js accountName) |
There was a problem hiding this comment.
Suggested change
| echo "const fs = require('fs');" > gettoken.js | |
| echo "const fileContents = fs.readFileSync('sas-token', 'utf8');" >> gettoken.js | |
| echo "const token = JSON.parse(fileContents);" >> gettoken.js | |
| echo "console.log(token[process.argv[2]])" >> gettoken.js | |
| sas_token=$(node ./gettoken.js sasToken) | |
| account_name=$(node ./gettoken.js accountName) | |
| sas_token=$(jq -r '.sasToken' sas-token) | |
| account_name=$(jq -r '.accountName' sas-token) |
There was a problem hiding this comment.
JQ is not available on Windows runners.
There was a problem hiding this comment.
We can make this a todo along with #47897 (comment)
There was a problem hiding this comment.
Ah yeah for sure, didn't realize jq wasn't in that image, should be easy to install with choco in our scripts
There was a problem hiding this comment.
| shell: powershell | ||
| if: ${{ inputs.target-platform == 'win' }} | ||
| run: | | ||
| Set-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" -Name "LongPathsEnabled" -Value 1 -Type DWord |
There was a problem hiding this comment.
Can we take this as a TODO to load this into the windows runner image?
|
No Release Notes |
This was referenced Jul 30, 2025
|
I have automatically backported this PR to "38-x-y", please check out #47912 |
|
I have automatically backported this PR to "35-x-y", please check out #47913 |
|
I have automatically backported this PR to "36-x-y", please check out #47914 |
|
I have automatically backported this PR to "37-x-y", please check out #47915 |
jkleinsc
added a commit
that referenced
this pull request
Jul 30, 2025
This was referenced Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR moves our GHA runners to a new arc cluster with better capacity.
Checklist
npm testpassesRelease Notes
Notes: none