Skip to content

Solves easy lints #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Conversation

workingjubilee
Copy link
Contributor

@workingjubilee workingjubilee commented Aug 18, 2019

This PR addresses a few lints that were reported on https://app.sourcelevel.io/github/elixirscript/elixirscript and I can include more if desired.

All the tests for the files I updated pass. There are definitely broken tests in other parts of the app, apparently on the Elixir side. I would like to dig into those more and get to fixing, but I figured I'd start with some basic cleanup before commencing real work, and that this change is complete in itself.

Edit: The command "wget -o ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}" failed and exited with 8 during . Why are you like this, Travis? What have I done to you?

@sourcelevel-bot
Copy link

Hello, @workingjubilee! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 5 fixed issues! 🎉

You can see more details about this review at https://app.sourcelevel.io/github/elixirscript/elixirscript/pulls/492.

@bryanjos bryanjos merged commit 6ade606 into elixirscript:master Aug 19, 2019
@bryanjos
Copy link
Collaborator

Thanks! As for travis, I think I'll dig in now and see what I can fix there. It's been a while since that was looked at and can be made better

@bryanjos
Copy link
Collaborator

FYI I updated the travis file in master. Looks like 4 tests are currently failing but it at leasts updates the CI configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants