[WIP] Add buffer and thread modules #152
Conversation
rust_src/crates/lisp/src/eval.rs
Outdated
| /// Thus, (funcall \\='cons \\='x \\='y) returns (x . y). | ||
| /// usage: (funcall FUNCTION &rest ARGUMENTS) | ||
| #[allow(unused_assignments)] | ||
| pub fn funcall(args: &mut [LispObject]) -> LispObject { |
There was a problem hiding this comment.
Here's my take on this - I think we will get ourselves into trouble long term if we copy too much of remacs re-implementations. I think copying remacs wrapper classes, and simple one liners (like intern below) are good, but larger functions like funcall will cause issues. Instead, I think it would be better if we made these functions 'safe wrappers' around the native C functions - that way we keep the implementations aligned, but we are still writing idiomatic Rust and aren't littering the code with unsafe and as_mut_ptr() calls .
There was a problem hiding this comment.
Yeah I was also hesitant to do this. I'll look for an alternative.
|
@DavidDeSimone I removed funcall. |
|
Oh I forgot that I still need to find an alternative for funcall in call =) |
| pub struct ThreadState {} | ||
|
|
||
| impl ThreadState { | ||
| pub fn current_buffer_unchecked() -> LispBufferRef { |
There was a problem hiding this comment.
since this is unchecked do we want to mark it unsafe? What it is doing seems pretty unsafe to me.
There was a problem hiding this comment.
I'd say no. It doesn't help anyone.
Usually marking a function unsafe communicates to the caller that they need to enforce a certain invariant or they will cause UB. You're not meant to tinker with the current_thread_pointer anyway, so safe rust will not cause UB in this function.
The same goes for the other function.
This is some code that I need for git stuff. The remacs macro
callcombined withinternare good for testing purposes.It seems they removed
check_cons_listfromfuncallupstream, does anybody see why ?