ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

GustavoARSilva · Stefan Schmidt · commit 0be7fc7e08e7 · 2017-11-06T16:27:55.000+01:00
It seems that this is a copy/paste error and the proper bit masking is: BIT_TXNIE | BIT_RXIE This issue was detected with the help of Coccinelle. Reported-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Fixes: 7d84054 ("mrf24j40: replace magic numbers") Acked-by: Alan Ott <alan@signal11.us> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
@@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)
 
 	/* Set TXNIE and RXIE. Disable Interrupts */
 	regmap_update_bits(devrec->regmap_short, REG_INTCON,
-			   BIT_TXNIE | BIT_TXNIE, BIT_TXNIE | BIT_TXNIE);
+			   BIT_TXNIE | BIT_RXIE, BIT_TXNIE | BIT_RXIE);
 }
 
 static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)

Original file line number	Diff line number	Diff line change
`@@ -635,7 +635,7 @@ static void mrf24j40_stop(struct ieee802154_hw *hw)`
`635`	`635`
`636`	`636`	`/* Set TXNIE and RXIE. Disable Interrupts */`
`637`	`637`	`regmap_update_bits(devrec->regmap_short, REG_INTCON,`
`638`		`- BIT_TXNIE \| BIT_TXNIE, BIT_TXNIE \| BIT_TXNIE);`
	`638`	`+ BIT_TXNIE \| BIT_RXIE, BIT_TXNIE \| BIT_RXIE);`
`639`	`639`	`}`
`640`	`640`
`641`	`641`	`static int mrf24j40_set_channel(struct ieee802154_hw *hw, u8 page, u8 channel)`